Move data_samplers.py from legacy to training.datasets & add DistributedSignalHandler to DataLoader workers
#2068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolergi-nv
force-pushed
the
dist_signal_handler_dataloader
branch
from
c9a12d9 to
c01d4db
Compare
asolergi-nv
force-pushed
the
dist_signal_handler_dataloader
branch
from
c01d4db to
ebfbb1e
Compare
|
/ok to test ebfbb1e |
asolergi-nv
added
the
Expert Review
ko3n1g
approved these changes
Nov 3, 2025
ananthsub
reviewed
Nov 3, 2025
asolergi-nv
changed the title
data_samplers.py from legacy to core.datasets & add DistributedSignalHandler to DataLoader workersdata_samplers.py from legacy to training.datasets & add DistributedSignalHandler to DataLoader workers
asolergi-nv
added
Final Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Move
data_samplers.pyfromlegacytocore.datasets& addDistributedSignalHandlerto DataLoader workers. Now the user can also select other signals, not onlySIGTERM. This will help us ensure that we will successfully and gracefully exit the job. In some setups, the DataLoader workers are kept alive, so the job doesn’t finish until it hits the job wall time limit.Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
[email protected]or[email protected].Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.